Skip to content

Restore create_dir_all method for directory creation#260

Merged
alexcrichton merged 1 commit into
composefs:masterfrom
CriesofCarrots:create_dir_all
Aug 12, 2021
Merged

Restore create_dir_all method for directory creation#260
alexcrichton merged 1 commit into
composefs:masterfrom
CriesofCarrots:create_dir_all

Conversation

@CriesofCarrots
Copy link
Copy Markdown
Contributor

@CriesofCarrots CriesofCarrots commented Aug 11, 2021

https://github.com/alexcrichton/tar-rs/releases/tag/0.4.36 can be breaking for callers using unpack_in() to unpack to the same directory in parallel. If multiple threads race to create the same parent, the later ones will now error; #259 switches to create_dir(), which errors if a folder already exists.
With the new validation added in #259 , it seems reasonable to restore create_dir_all() for the actual creation. What do you think?

@alexcrichton alexcrichton merged commit 8eecbf5 into composefs:master Aug 12, 2021
@alexcrichton
Copy link
Copy Markdown
Collaborator

Thanks!

charliermarsh added a commit to astral-sh/tokio-tar that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants