tests: Don't assume /dev/loop0 exists#328
Merged
Merged
Conversation
It doesn't by default on e.g. current Fedora and RHEL systems. I suspect most people so far have been running this on Ubuntu which uses snaps which use loopback devices, but we can't rely on that. For test coverage here, ultimately there's not really a good block device to rely on without going through a lot of special casing. Let's just test character devices.
Contributor
|
+1 since this also does not work on Arch Linux |
Merged
Collaborator
|
Thanks! |
ararslan
pushed a commit
to ararslan/binstall-tar
that referenced
this pull request
Jun 6, 2024
It doesn't by default on e.g. current Fedora and RHEL systems. I suspect most people so far have been running this on Ubuntu which uses snaps which use loopback devices, but we can't rely on that. For test coverage here, ultimately there's not really a good block device to rely on without going through a lot of special casing. Let's just test character devices. (cherry picked from commit a37c9b6)
charliermarsh
added a commit
to astral-sh/tokio-tar
that referenced
this pull request
Feb 5, 2025
## Summary Ports composefs/tar-rs#246 to `async-tar`. Also includes composefs/tar-rs#328 which came later as a test-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't by default on e.g. current Fedora and RHEL systems. I suspect most people so far have been running this on Ubuntu which uses snaps which use loopback devices, but we can't rely on that.
For test coverage here, ultimately there's not really a good block device to rely on without going through a lot of special casing.
Let's just test character devices.