Rename expectedBuyAmount to buyAmount#62
Merged
kevincheng96 merged 2 commits intomainfrom Aug 8, 2024
Merged
Conversation
hayesgm
reviewed
Aug 7, 2024
Contributor
hayesgm
left a comment
hayesgm
left a comment
There was a problem hiding this comment.
looks good-- curious how many places we need to change code to match this 😢
Contributor
Author
It should only require a client-level change. We don't touch the action context here. |
Contributor
|
Yeah, though in both Elixir and Swift now. Well, let's see it out, a small change should be an easier one to understand. |
hayesgm
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the swap functions can support both exact input and exact output swaps, the buy amount is not always an expected amount. It can be the actual buy amount in an exact output swap.