Merged
Conversation
Copy over current progress to Oscar
Pull from Andrew to Oscar (file upload working)
Into Oscar Exams temp branch
Exams oscar to the master in oscar's fork
hkn web changes
Pull main CompServ to ochan1
Contributor
Author
|
The original bug from this branch: Used patch from neutronX/django-markdownx#163 |
Contributor
Author
|
All "markdownify" function calls shall need to be called from the one made in "hknweb.utils" for security purposes |
Contributor
Author
|
There is no need to modify the backend data, but if any malicious HTML code is pushed, it will stay on the backend However, before showing up to the end-user, the text is sanitized |
…into eventsMarkdownPatch
sammaher1
approved these changes
Jan 3, 2021
Contributor
sammaher1
left a comment
sammaher1
left a comment
There was a problem hiding this comment.
Looks good, tried to inject various alerts and images into event descriptions and urls, which all did not succeed. Markdownify being added as a dependency seems like a worthwhile trade for the security and access to markdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.