compulim · compulim · Sep 9, 2023 · Sep 9, 2023 · Sep 9, 2023 · Sep 9, 2023
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Updates `tsconfig.json` to extend from [`@tsconfig/strictest`](https://npmjs.com/package/@tsconfig/strictest), by [@compulim](https://github.com/compulim), in PR [#21](https://github.com/compulim/use-ref-from/pull/21)
+   - Development dependencies
+      - [`@types/react@18.2.21`](https://npmjs.com/package/@types/react)
+      - [`@types/react-dom@18.2.7`](https://npmjs.com/package/@types/react-dom)
+      - [`esbuild@0.19.2`](https://npmjs.com/package/esbuild)
+      - [`typescript@5.2.2`](https://npmjs.com/package/typescript)
+
 ### Fixed
 
 - Fixes [#19](https://github.com/compulim/use-ref-from/issues/19). Updated `exports` field to workaround [TypeScript resolution bug](https://github.com/microsoft/TypeScript/issues/50762), by [@compulim](https://github.com/compulim), in PR [#20](https://github.com/compulim/use-ref-from/pull/20)

diff --git a/packages/pages/.gitignore b/packages/pages/.gitignore
@@ -1,4 +1,3 @@
 /node_modules/
 /package-lock.json
-/public/static/css/main.css
-/public/static/js/main.js
+/public/static/
diff --git a/packages/pages/package.json b/packages/pages/package.json
@@ -3,24 +3,25 @@
   "version": "0.0.0-0",
   "description": "",
   "scripts": {
-    "build": "npm run build:typescript && npm run build:esbuild",
-    "build:esbuild": "esbuild --bundle --entry-names=[dir]/[ext]/main --minify --outdir=./public/static/ ./src/index.tsx",
-    "build:typescript": "tsc --project ./src/tsconfig.json",
+    "build": "esbuild --bundle --entry-names=[name]/[ext]/main --minify --outdir=./public/static/ --sourcemap app=./src/app/index.tsx",
     "bump": "npm run bump:prod && npm run bump:dev && npm run bump:auditfix",
     "bump:auditfix": "npm audit fix || exit 0",
     "bump:dev": "if [ `cat package.json | jq -r '(.devDependencies // {}) | length'` -ne 0 ]; then npm install $(cat package.json | jq -r '(.pinDependencies // {}) as $p | ((.devDependencies // {}) | keys) | map(. + \"@\" + ($p[.] // [\"latest\"])[0]) | .[]'); fi",
     "bump:prod": "if [ `cat package.json | jq -r '(.dependencies // {}) | length'` -ne 0 ]; then npm install --save-exact $(cat package.json | jq -r '(.pinDependencies // {}) as $p | ((.dependencies // {}) | keys) | map(. + \"@\" + ($p[.] // [\"latest\"])[0]) | .[]'); fi",
     "postbump": "cat package.json | jq '. + (.dependencies = (((.dependencies // {}) + (.localPeerDependencies // {})) | to_entries | sort_by(.key) | from_entries)) | (.devDependencies = (((.devDependencies // {}) + (.localPeerDevDependencies // {})) | to_entries | sort_by(.key) | from_entries))' > package-temp.json && mv package-temp.json package.json",
     "prebump": "cat package.json | jq '(((.localPeerDependencies // {}) | keys | map([\"dependencies\", .])) + ((.localPeerDevDependencies // {}) | keys | map([\"devDependencies\", .]))) as $localPeerPaths | delpaths($localPeerPaths)' > package-temp.json && mv package-temp.json package.json",
-    "start": "esbuild --bundle --entry-names=[dir]/[ext]/main --minify --outdir=./public/static/ --servedir=./public ./src/index.tsx"
+    "precommit": "npm run precommit:typescript",
+    "precommit:typescript": "tsc --project ./src/tsconfig.json",
+    "reinstall": "rm -r node_modules package-lock.json && npm install",
+    "start": "npm run build -- --servedir=./public"
   },
   "author": "William Wong (https://github.com/compulim)",
   "license": "MIT",
   "devDependencies": {
-    "@types/react": "^18.0.28",
-    "@types/react-dom": "^18.0.11",
-    "esbuild": "^0.17.10",
-    "typescript": "^4.9.5"
+    "@types/react": "^18.2.21",
+    "@types/react-dom": "^18.2.7",
+    "esbuild": "^0.19.2",
+    "typescript": "^5.2.2"
   },
   "dependencies": {
     "react": "18.2.0",

diff --git a/packages/pages/public/index.html b/packages/pages/public/index.html
@@ -2,10 +2,10 @@
 <html lang="en">
   <head>
     <title>use-ref-from demo</title>
-    <link href="./static/css/main.css" rel="stylesheet" type="text/css" />
+    <link href="./static/app/css/main.css" rel="stylesheet" type="text/css" />
   </head>
   <body>
     <div id="root"></div>
-    <script crossorigin="anonymous" src="./static/js/main.js"></script>
+    <script crossorigin="anonymous" src="./static/app/js/main.js"></script>
   </body>
 </html>
diff --git a/packages/pages/src/App.tsx → packages/pages/src/app/App.tsx b/packages/pages/src/App.tsx → packages/pages/src/app/App.tsx
diff --git a/packages/pages/src/index.tsx → packages/pages/src/app/index.tsx b/packages/pages/src/index.tsx → packages/pages/src/app/index.tsx
diff --git a/packages/pages/src/tsconfig.json b/packages/pages/src/tsconfig.json
@@ -2,10 +2,10 @@
   "compilerOptions": {
     "esModuleInterop": true,
     "jsx": "react",
-    "moduleResolution": "nodenext",
+    "lib": ["DOM", "ESNext"],
+    "moduleResolution": "Bundler",
     "noEmit": true,
     "strict": true,
     "target": "ESNext"
-  },
-  "exclude": ["**/*.spec.*", "**/*.test.*"]
+  }
 }
diff --git a/packages/use-ref-from/package-lock.json b/packages/use-ref-from/package-lock.json
diff --git a/packages/use-ref-from/package.json b/packages/use-ref-from/package.json
@@ -86,6 +86,8 @@
     "@babel/preset-env": "^7.22.9",
     "@babel/preset-typescript": "^7.22.5",
     "@testing-library/react-hooks": "^8.0.1",
+    "@tsconfig/strictest": "^2.0.2",
+    "@types/jest": "^29.5.4",
     "@types/react": "^17.0.62",
     "jest": "^29.6.1",
     "jest-environment-jsdom": "^29.6.1",

diff --git a/packages/use-ref-from/src/tsconfig.declaration.json b/packages/use-ref-from/src/tsconfig.declaration.json
@@ -2,7 +2,8 @@
   "compilerOptions": {
     "declaration": true,
     "emitDeclarationOnly": true,
-    "moduleResolution": "NodeNext"
+    "noEmit": false
   },
+  "exclude": ["**/*.spec.*", "**/*.test.*", "__test__/**/*"],
   "extends": "./tsconfig.json"
 }
diff --git a/packages/use-ref-from/src/tsconfig.json b/packages/use-ref-from/src/tsconfig.json
@@ -2,7 +2,10 @@
   "compilerOptions": {
     "esModuleInterop": true,
     "jsx": "react",
+    "module": "NodeNext",
+    "moduleResolution": "NodeNext",
+    "noEmit": true,
     "strict": true
   },
-  "exclude": ["**/*.spec.*", "**/*.test.*"]
+  "extends": "@tsconfig/strictest/tsconfig.json"
 }
diff --git a/packages/use-ref-from/src/useRefFrom.spec.js b/packages/use-ref-from/src/useRefFrom.spec.js
@@ -76,8 +76,9 @@ test('should not be settable', () => {
   // THEN: It should throw a getter-only exception.
   expect(
     () =>
-      // Exception thrown when `result.current` getter is called.
+      // Exception thrown when `result.current` setter is called.
       renderHook(() => {
+        // @ts-expect-error Intentionally setting the value to throw exception.
         useRefFrom(123).current = 234;
       }).result.current
   ).toThrow('Cannot set property current of #<Object> which has only a getter');