Allow e2e tests to use configurable executable#365
Merged
Conversation
Add DUCT_TEST_EXECUTABLES env var to override the duct command used in e2e tests. By default, tests run twice with both "duct" and "con-duct run" entry points. External builds (e.g., PyInstaller) can set this to test their executable against the same e2e suite. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configurable executable testing in e2e tests through the DUCT_TEST_EXECUTABLES environment variable. By default, tests run with both duct and con-duct run entry points, and external builds (like PyInstaller) can override this to test their own executables.
Key changes:
- Introduced
DUCT_TEST_EXECUTABLESenvironment variable for specifying test executables - Created a pytest fixture
duct_cmdthat parametrizes tests across different executables - Updated all e2e test functions to accept and use the
duct_cmdfixture
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Handle spaces after commas in DUCT_TEST_EXECUTABLES. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
@CodyCBakerPhD ran against https://github.com/codycbakerphd/duct-releases/ and smoketests are green! |
CodyCBakerPhD
approved these changes
Jan 9, 2026
Contributor
|
Great to hear! |
This was referenced Jan 9, 2026
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DUCT_TEST_EXECUTABLESenv var to configure which executable(s) the e2e tests useductand once withcon-duct runUsage
Default (tests both entry points):
External executable:
DUCT_TEST_EXECUTABLES="./dist/con-duct run" pytest test/duct_main/test_e2e.py -vTest plan
Default test run (both entry points)
PyInstaller executable test run
🤖 Generated with Claude Code