Skip to content

ci: run tests on all PRs, remove yamllint#374

Merged
asmacdo merged 3 commits intocon:mainfrom
asmacdo:ci-all-prs
Jan 23, 2026
Merged

ci: run tests on all PRs, remove yamllint#374
asmacdo merged 3 commits intocon:mainfrom
asmacdo:ci-all-prs

Conversation

@asmacdo
Copy link
Copy Markdown
Member

@asmacdo asmacdo commented Jan 23, 2026

Summary

  • Remove branch filter from pull_request trigger so tests run on PRs targeting any branch
  • Remove yamllint from pre-commit (no YAML files to lint besides config files themselves)

Test plan

  • Workflow syntax is valid
  • Pre-commit passes

🤖 Generated with Claude Code

- Remove branch filter from pull_request trigger
- Remove yamllint from pre-commit (no YAML files to lint)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings January 23, 2026 18:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the CI/CD configuration by removing the branch filter from the test workflow so tests run on all pull requests regardless of target branch, and removes yamllint from pre-commit since the repository only has configuration YAML files already validated by the check-yaml hook.

Changes:

  • Remove branch filter from pull_request trigger in test workflow to run tests on all PRs
  • Remove yamllint hook from pre-commit configuration and delete .yamllint.yaml config file
  • Clean up trailing whitespace in tox.ini and CONTRIBUTING.rst

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/test.yaml Removes branch filter to allow tests on PRs targeting any branch
.pre-commit-config.yaml Removes yamllint hook as it's redundant with check-yaml for config files
.yamllint.yaml Deletes yamllint configuration file no longer needed
CONTRIBUTING.rst Removes trailing whitespace on line 44
tox.ini Removes trailing empty line at end of file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/test.yaml
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@asmacdo asmacdo added the semver-tests Add or improve existing tests label Jan 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.19%. Comparing base (f35633e) to head (d52f961).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   91.38%   91.19%   -0.19%     
==========================================
  Files           8        8              
  Lines        1056     1056              
  Branches      138      138              
==========================================
- Hits          965      963       -2     
- Misses         69       70       +1     
- Partials       22       23       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asmacdo asmacdo merged commit c491bb4 into con:main Jan 23, 2026
28 of 30 checks passed
@asmacdo asmacdo deleted the ci-all-prs branch January 23, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-tests Add or improve existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants