Skip to content

Conversation

@asmacdo
Copy link
Member

@asmacdo asmacdo commented Jan 23, 2026

Summary

  • Extract SigIntHandler class from duct_main.py to new _signals.py module
  • Remove unused FrameType import from duct_main.py

Part of #372

Test plan

  • All 346 tests pass
  • Lint passes
  • Typing passes

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.42%. Comparing base (64e72c9) to head (1786925).
⚠️ Report is 3 commits behind head on duct-main-breakup.

Files with missing lines Patch % Lines
src/con_duct/_signals.py 48.00% 13 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           duct-main-breakup     #380      +/-   ##
=====================================================
- Coverage              91.55%   91.42%   -0.13%     
=====================================================
  Files                     11       12       +1     
  Lines                   1077     1084       +7     
  Branches                 138      138              
=====================================================
+ Hits                     986      991       +5     
- Misses                    69       70       +1     
- Partials                  22       23       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asmacdo asmacdo merged commit 4dc706d into con:duct-main-breakup Jan 23, 2026
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant