Specify that the regexes are Python regexes and link to the Python docs#110
Merged
yarikoptic merged 1 commit intomasterfrom Jun 14, 2021
Merged
Specify that the regexes are Python regexes and link to the Python docs#110yarikoptic merged 1 commit intomasterfrom
yarikoptic merged 1 commit intomasterfrom
Conversation
yarikoptic
approved these changes
Jun 14, 2021
Member
yarikoptic
left a comment
yarikoptic
left a comment
There was a problem hiding this comment.
Looks LGTM, thank you @jwodder ! Sorry it took me "long" to review/approve so conflicts piled up
| .. _DataLad: https://www.datalad.org | ||
|
|
||
| .. _Python regular expressions: https://docs.python.org/3/library/re.html | ||
| #regular-expression-syntax |
Member
There was a problem hiding this comment.
note to myself: tested in github README.rst renderer for the diff -- it manages to bring the #fragment properly into the url
Contributor
Author
|
@yarikoptic Conflict resolved. |
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
===========================================
- Coverage 72.52% 44.80% -27.73%
===========================================
Files 10 9 -1
Lines 899 895 -4
Branches 134 134
===========================================
- Hits 652 401 -251
- Misses 193 493 +300
+ Partials 54 1 -53
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.