Skip to content

Improve headers sent in HTTP requests#182

Merged
jwodder merged 3 commits intomasterfrom
headers
Nov 9, 2023
Merged

Improve headers sent in HTTP requests#182
jwodder merged 3 commits intomasterfrom
headers

Conversation

@jwodder
Copy link
Copy Markdown
Contributor

@jwodder jwodder commented Nov 9, 2023

No description provided.

@jwodder jwodder added the patch Increment the patch version when merged label Nov 9, 2023
@yarikoptic
Copy link
Copy Markdown
Member

conflicts came up

@jwodder
Copy link
Copy Markdown
Contributor Author

jwodder commented Nov 9, 2023

@yarikoptic Conflicts resolved.

@yarikoptic
Copy link
Copy Markdown
Member

CI isn't happy

@jwodder
Copy link
Copy Markdown
Contributor Author

jwodder commented Nov 9, 2023

@yarikoptic We were running the "Test fetching tinuous' logs" workflow so often that the step for cloning con/tinuous-inception (which apparently isn't using an authenticated token?) failed due to exhausting rate limits.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 9, 2023

Codecov Report

Merging #182 (7f2bea8) into master (22a29f3) will increase coverage by 0.10%.
The diff coverage is 87.50%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   65.66%   65.76%   +0.10%     
==========================================
  Files          10       10              
  Lines        1366     1370       +4     
  Branches      284      284              
==========================================
+ Hits          897      901       +4     
  Misses        390      390              
  Partials       79       79              
Files Coverage Δ
src/tinuous/base.py 77.84% <100.00%> (+0.51%) ⬆️
src/tinuous/github.py 55.72% <0.00%> (ø)

GitHub doesn't seem to like setting "Accept: application/zip" when download a
log URL, even though the Content-Type for the response is application/zip.
@jwodder jwodder merged commit e0cdec4 into master Nov 9, 2023
@jwodder jwodder deleted the headers branch November 9, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants