Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
|
|
||
| if platform.system() == "Windows": | ||
| run("cmake --preset conan-default") | ||
| run("cmake --preset conan-release") |
There was a problem hiding this comment.
Why? Has the default generator changed to Ninja? I don't see that.
There was a problem hiding this comment.
Sorry, I'm running Ninja by default locally. I'll revert it.
| sdl/[~2.28] | ||
|
|
||
| [options] | ||
| libtiff/*:lzma=False |
There was a problem hiding this comment.
But is libtiff broken for Windows with the default lzma=True option? It would be good to know the underlying problem
There was a problem hiding this comment.
When building xz_utils we have a few error that breaks the CI:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oaidl.h(487,17): error C2059: syntax error: '/' [C:\J2\workspace\Examples2.0_PR-192\85ca\e3ff.conan\p\b\xz_utd86488799d7c1\b\build-release\liblzma.vcxproj]
(compiling source file '../src/src/common/tuklib_physmem.c')
https://github.com/user-attachments/files/23366997/sdl_tutorial.log
It looks like tuklib_physmem.c is compiled with Windows headers that require C++. Wrong language mode maybe?
Still, I want to have a green build first, only to make sure we don't have more errors besides this one.
There was a problem hiding this comment.
could we open an issue in Conan Center about this?
I suspect its the version of the Windows SDK - our CI had no issues with this
There was a problem hiding this comment.
Done, new issue reported: conan-io/conan-center-index#28835
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
|
Okay, I can reproduce the CI error locally. I comes from that old Windows SDK version 10.0.17763.0 used in the CI: xz_utils-5.8.1-windows-amd64-msvc194-sdk10.0.17763.0-reelease.log Using one version later (10.0.18362.0) it works perfectly: xz_utils-5.8.1-windows-amd64-msvc194-sdk10.0.18362.0-reelease.log And, using a more recent version it works as well: xz_utils-5.8.1-windows-amd64-msvc194-sdk10.0.26100.0-reelease.log Microsoft marks those SDK version as deprecated: https://developer.microsoft.com/en-us/windows/downloads/sdk-archive/index-legacy We will need or update the SDK version in CI, or just use libtiff without xz_utils. |
|
I'm merging this so we can have the CI green, as we are planning to move the CI to GitHub Actions that can be addressed when we migrate. |
4 participants
fixes #198