-
Notifications
You must be signed in to change notification settings - Fork 46
conan-center: add meson to exception list of KB-H019 (it contains a cmake script) #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just To be clear, the pkgconf fails independantly of this hook: |
|
Indeed, the pkgconf recipe isn't finished yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is still fuzzy to me: this hook failure happened for meson and all projects requiring meson, yet the bot never shows this hook failure, except when the build fails for some other reason. Is it what's supposed to happen ?
|
I've added this folder to builddirs conan-io/conan-center-index#4420, it's a recurrent source of misleading errors reports in PRs, and it pollutes logs for consumers. |
|
Oh I see, this PR is still opened 😢 |
|
this may not be needed any more, now that conan-io/conan-center-index#4420 is merged |
|
I think this PR needs to be updated with latest changes in master branch to make the CI green |
|
@madebr this PR can be closed, with conan-io/conan-center-index#4420 merged |
|
Closed it is then! |
This pr adds meson to the exception list of KB-H019.
This should fix the CI failures I'm having with pkgconf at conan-io/conan-center-index#1013 (comment)
I've just checked meson 0.54.3 and it contains the following cmake script:
I've copied the contents of the script here below.
I think an exception is required instead of adding it to
cpp_info.builddirs.contents of meson's preload.cmake
/cc @uilianries @ericLemanissier