Create emptyDir for worker when using kind Deployment #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems the root container volume is read-only, so we can't write whatever we want to it anymore. Resolved by copying what we do in the StatefulSet and creating an emptyDir volume for the work dir Signed-off-by: Taylor Silva <dev@taydev.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Issue
Fixes #255
Why do we need this PR?
It seems the root container volume is read-only, so we can't write whatever we want to it anymore. Resolved by copying what we do in the StatefulSet and creating an emptyDir volume for the work dir. If someone is already using the workaround from #255, this change won't break anything for them, it'll skip creating the emptyDir.
Contributor Checklist
README.mdmasteris for changes related to the current release of theconcourse/concourse:latestimage and should be good to publish immediatelydevis for changes related to the next release of Concourse (aka unpublished code onmasterin concourse/concourse)Reviewer Checklist
masterordev)