Fetching new tags doesn’t work when tag filtering is enabled (sometimes)

[Igor-rockawayx]

Summary

When using tag filtering with a git resource, new tags are not being fetched. The resource seems to ignore newly pushed tags unless filtering is disabled and enabled again. In the example below the tag filtering is enabled:

But it doesn't see this tag: https://github.com/aptos-labs/aptos-core/releases/tag/aptos-node-v1.34.4-hotfix even then triggered manually. The issue is not isolated to this specific repo but happens from time to time to any git resouce that has tag filtering enbabled.

Deployment type: BM server with Ubuntu 22.04.5 LTS

Steps to Reproduce

---
resources:
  - name: aptos-repo
    type: git
    source:
      uri: https://github.com/aptos-labs/aptos-core.git
      fetch_tags: true
      version_depth: 500
      tag_filter: "aptos-node*"

Expected Results

No response

Actual Results

No response

Web Node(s) configuration

No response

Worker(s) configuration

worker.env:

CONCOURSE_WORK_DIR=XXX
CONCOURSE_TSA_HOST=127.0.0.1:2222
CONCOURSE_TSA_PUBLIC_KEY=XXX
CONCOURSE_TSA_WORKER_PRIVATE_KEY=XXX
CONCOURSE_RUNTIME=containerd
CONCOURSE_CONTAINERD_ALLOW_HOST_ACCESS=true
CONCOURSE_BAGGAGECLAIM_DRIVER=overlay
CONCOURSE_CONTAINERD_DNS_SERVER=XXX

Concourse Version

7.14.0

Browser (if applicable)

No response

Did this use to work?

No, 7.11.2 also had the same issue - sometimes not fetching new tags when tag filtering enabled

[analytically]

The issue is that when a tag like aptos-node-v1.34.4-hotfix is created on a branch that isn't merged into the default branch, the check script's git tag --merged HEAD filter excludes it. Since you have version_depth: 500, the resource looks at tags within the last 500 commits of HEAD, but if the hotfix tag is on an unmerged branch, it won't be in that commit history.

[Igor-rockawayx]

okay, thanks for the clarification. I've noticed this happening on quiet a few git repos, are there any config changes I could make that would fetch tags from unmerged branch? I've found https://github.com/Sarquella/concourse-git-tag-resource which might help, but last release was 2021 so I'm not sure how compatible it's going to be with the new versions of Concourse

[analytically]

I'm working on a patch!

[Igor-rockawayx]

Hey @analytically, do you have any update on this?