Add Timestampe git metadata file#306
Closed
ngehrsitz wants to merge 1 commit intoconcourse:masterfrom
Closed
Conversation
ngehrsitz
force-pushed
the
master
branch
2 times, most recently
from
cd55143 to
6cb8893
Compare
This commit adds generation of a timestamp metadata file that can be used to tag builds. This is useful when running parallel builds of a pipeline to determine which version is more up to date after pushing to a build storage like artifactory. Signed-off-by: ngrsdhbw <gehrsitz.norman@student.dhbw-karlsruhe.de>
YoussB
suggested changes
Apr 14, 2020
Contributor
YoussB
left a comment
YoussB
left a comment
There was a problem hiding this comment.
This feature seems like a really solid idea, thanks! Can we get a test for this? The other 'additional files populated' have tests here. I'm trying to ask for tests whenever possible to prevent regressions since this resource will (one day) get rewritten.
Contributor
|
Hey @ngrsdhbw, Thanks! |
Contributor
Author
|
I added the missing tests and a configuration option to choose the timestamp format on my branch git-timestamp. @YoussB could you reopen the pull request or should i make a new one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds generation of a timestamp metadata file that can be used to tag builds. This is useful when running parallel builds of a pipeline to determine which version is more up to date after pushing to a build storage like artifactory.