Added committer_author to the outputs for use in slack notifications#366
Merged
taylorsilva merged 6 commits intoconcourse:masterfrom Jul 23, 2021
Merged
Added committer_author to the outputs for use in slack notifications#366taylorsilva merged 6 commits intoconcourse:masterfrom
taylorsilva merged 6 commits intoconcourse:masterfrom
Conversation
Signed-off-by: Jordan Dziat <jdziat@ltvco.com>
Signed-off-by: Jordan Dziat <jdziat@ltvco.com>
Signed-off-by: Jordan Dziat <jdziat@ltvco.com>
Signed-off-by: Jordan Dziat <jdziat@ltvco.com>
Signed-off-by: Jordan Dziat <jdziat@ltvco.com>
Signed-off-by: Jordan Dziat <jdziat@ltvco.com>
Contributor
Author
|
@taylorsilva Any chance we can get this merged into the branch? It's a simple one liner that would help us a lot. |
taylorsilva
approved these changes
Jul 23, 2021
Member
taylorsilva
left a comment
taylorsilva
left a comment
There was a problem hiding this comment.
LGTM
We assign PR's to someone every morning during our standup, so you shouldn't have to worry about us missing a PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of our workflow we use the .git directory files to populate out slack notifications. Instead of running a secondary command or task we'd like the git resource to output the author name into a separate file. This way we can avoid instances of unusable or appended emails from being sent to our notification channels.