-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add owa - foundation multimodal desktop agent toolbox #30109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/pygobject-stubs/meta.yaml:
For recipes/pygobject-stubs/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15184816622. Examine the logs at this URL for more detail. |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-python ready for review! |
|
@conda-forge-admin, please ping team |
|
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
|
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
|
@conda-forge-admin, please ping conda-forge/python |
|
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/python and so here I am doing that. |
recipes/bettercam/meta.yaml
Outdated
| sha256: 122cc0e905cb40be8f2a26e46ee587bae40c10eb9c23201370a54e68b84a0940 | ||
|
|
||
| build: | ||
| skip: true # [not win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it ca be noarch python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due to lack of non-windows build in comtypes(which is dependency of bettercam), the build fails. Also since the bettercam utilizes Windows API, installing this on non-windows OS has no effects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do not install comtypes, running import bettercam will result in an error because it contains a line that imports comtypes. In other words, you can't even install the package without it, even if it doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due to lack of non-windows build in
comtypes(which is dependency ofbettercam), the build fails. Also since thebettercamutilizes Windows API, installing this on non-windows OS has no effects.
See https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-packages-with-os-specific-dependencies for a OS specific noarch package,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mean installing comtypes only on windows, the test does not work because import bettercam contains a line that imports comtypes. What's the solution you're thinking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a Windows only noarch. See https://github.com/conda-forge/dxcam-feedstock/blob/main/recipe/meta.yaml for an example.
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/bettercam/meta.yaml:
For recipes/bettercam/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15273158475. Examine the logs at this URL for more detail. |
|
@MilkClouds you have 10 recipes there. While that is convenient for you, it is quite a burden on the conda-forge voluntary reviewers. It may take a while until someone reviews them all. Or, if you want to speed things up, you can try to send 1 recipe per PR. |
|
@ocefpaf Sure, I know it's hard for reviewers to review. I can still somewhat break down the current PR based on this dependency graph, so I'll do that. Besides, once I did what you suggested, I think I broke a test that was working well outside of win64. |

Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).