Skip to content

Conversation

@MilkClouds
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/bettercam/meta.yaml, recipes/owa-env-desktop/meta.yaml, recipes/owa-cli/meta.yaml, recipes/owa-core/meta.yaml, recipes/owa-env-gst/meta.yaml, recipes/pygobject-stubs/meta.yaml, recipes/mcap/meta.yaml, recipes/mcap-owa-support/meta.yaml, recipes/ocap/meta.yaml, recipes/owa/meta.yaml) and found some lint.

Here's what I've got...

For recipes/pygobject-stubs/meta.yaml:

  • ❌ The top level meta key tests is unexpected
  • ❌ The recipe must have some tests.

For recipes/pygobject-stubs/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the test.requires section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15184816622. Examine the logs at this URL for more detail.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented May 22, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/owa-env-desktop/meta.yaml, recipes/pygobject-stubs/meta.yaml, recipes/mcap/meta.yaml, recipes/owa-cli/meta.yaml, recipes/owa-env-gst/meta.yaml, recipes/bettercam/meta.yaml, recipes/mcap-owa-support/meta.yaml, recipes/owa/meta.yaml, recipes/owa-core/meta.yaml, recipes/ocap/meta.yaml) and found it was in an excellent condition.

@MilkClouds
Copy link
Contributor Author

@conda-forge/help-python ready for review!

@MilkClouds
Copy link
Contributor Author

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@github-actions
Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@MilkClouds
Copy link
Contributor Author

@conda-forge-admin, please ping conda-forge/python

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/python and so here I am doing that.

sha256: 122cc0e905cb40be8f2a26e46ee587bae40c10eb9c23201370a54e68b84a0940

build:
skip: true # [not win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it ca be noarch python

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to lack of non-windows build in comtypes(which is dependency of bettercam), the build fails. Also since the bettercam utilizes Windows API, installing this on non-windows OS has no effects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do not install comtypes, running import bettercam will result in an error because it contains a line that imports comtypes. In other words, you can't even install the package without it, even if it doesn't work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to lack of non-windows build in comtypes(which is dependency of bettercam), the build fails. Also since the bettercam utilizes Windows API, installing this on non-windows OS has no effects.

See https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-packages-with-os-specific-dependencies for a OS specific noarch package,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mean installing comtypes only on windows, the test does not work because import bettercam contains a line that imports comtypes. What's the solution you're thinking?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a Windows only noarch. See https://github.com/conda-forge/dxcam-feedstock/blob/main/recipe/meta.yaml for an example.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/owa-core/meta.yaml, recipes/owa-env-desktop/meta.yaml, recipes/ocap/meta.yaml, recipes/owa-cli/meta.yaml, recipes/mcap-owa-support/meta.yaml, recipes/owa/meta.yaml, recipes/mcap/meta.yaml, recipes/owa-env-gst/meta.yaml, recipes/pygobject-stubs/meta.yaml, recipes/bettercam/meta.yaml) and found some lint.

Here's what I've got...

For recipes/bettercam/meta.yaml:

  • ❌ noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >={{ python_min }} in the run section of your recipe. You may also want to check the upstream source for the package's Python compatibility.

For recipes/bettercam/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use the pin python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15273158475. Examine the logs at this URL for more detail.

@ocefpaf
Copy link
Member

ocefpaf commented May 27, 2025

@MilkClouds you have 10 recipes there. While that is convenient for you, it is quite a burden on the conda-forge voluntary reviewers. It may take a while until someone reviews them all.

Or, if you want to speed things up, you can try to send 1 recipe per PR.

@MilkClouds
Copy link
Contributor Author

@ocefpaf Sure, I know it's hard for reviewers to review. I can still somewhat break down the current PR based on this dependency graph, so I'll do that.

Besides, once I did what you suggested, I think I broke a test that was working well outside of win64.
image

@MilkClouds MilkClouds closed this May 27, 2025
@MilkClouds MilkClouds mentioned this pull request May 27, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants