Skip to content

Do not error when PKG installer cannot change file ownership in HOME #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoesters merged 3 commits into from
Mar 23, 2026
+40 −4
Merged

Do not error when PKG installer cannot change file ownership in HOME #1185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdbd7fd
Do not error when PKG installer cannot change file ownership in HOME
marcoesters Mar 19, 2026
46a2c5b
Fix typo in Windows installer options
marcoesters Mar 23, 2026
463b785
Add owner to warnings
marcoesters Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion constructor/nsis/OptionsDialog.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ Function mui_AnaCustomOptions_Show
${Else}
${NSD_CreateLabel} 5% "$5u" 90% 20u \
"NOT recommended. This can lead to conflicts with other applications. \
Instead, use the Commmand Prompt and Powershell menus added \
Instead, use the Command Prompt and PowerShell menus added \
to the Windows Start Menu."
${EndIf}
IntOp $5 $5 + 20
Expand Down
5 changes: 4 additions & 1 deletion constructor/osx/run_conda_init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ if [[ "${USER}" != "root" ]]; then
if [[ -f "${file}" ]] || [[ -d "${file}" ]]; then
OWNER=$(stat -f "%u" "${file}" | id -un)
if [[ "${OWNER}" == "root" ]]; then
chown "${USER}" "${file}"
if ! chown "${USER}" "${file}"; then
MSG="WARNING! Unable to change ownership of ${file} (owned by ${OWNER})."
logger -p "install.warning" "${MSG}" || echo "${MSG}"
fi
fi
fi
file="${file%/*}"
Expand Down
18 changes: 16 additions & 2 deletions constructor/osx/run_installation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,22 @@ find "$PREFIX/pkgs" -type d -empty -exec rmdir {} \; 2>/dev/null || :
# This is not needed for the default install to ~, but if the user changes the
# install location, the permissions will default to root unless this is done.
chown -R "${USER}" "$PREFIX"
test -d "${HOME}/.conda" && chown -R "${USER}" "${HOME}/.conda"
test -f "${HOME}/.condarc" && chown "${USER}" "${HOME}/.condarc"
CONDA_DIR="${HOME}/.conda"
if [[ -d "${CONDA_DIR}" ]]; then
if ! chown -R "${USER}" "${CONDA_DIR}"; then
OWNER=$(stat -f "%u" "${CONDA_DIR}" | id -un)
MSG="WARNING: Unable to change ownership of ${CONDA_DIR} (owned by ${OWNER})."
logger -p "install.warning" "${MSG}" || echo "${MSG}"
fi
fi
CONDARC="${HOME}/.condarc"
if [[ -f "${CONDARC}" ]]; then
if ! chown "${USER}" "${CONDARC}"; then
OWNER=$(stat -f "%u" "${CONDARC}" | id -un)
MSG="WARNING: Unable to change ownership of ${CONDARC} (owned by ${OWNER})."
logger -p "install.warning" "${MSG}" || echo "${MSG}"
fi
fi

notify "Done! Installation is available in $PREFIX."

Expand Down
19 changes: 19 additions & 0 deletions news/1185-pkg-chown-permissions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* PKG: Do not fail the installer when ownership of files in `$HOME` cannot be changed. (#1177 via #1184)

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* <news item>
Loading