MSI: Add support for extra_envs by lrandersson · Pull Request #1186 · conda/constructor

lrandersson · 2026-03-20T14:55:55Z

Description

Added MSI support for extra_envs installations.

constructor/briefcase.py

Added _setup_envs_commands(info): builds environment configs (base + extra_envs) with name, prefix, lockfile, channels, and shortcuts
Updated _stage_dists() to include packages from _extra_envs_info
Updated render_templates() to use _setup_envs_commands()

constructor/briefcase/run_installation.bat

Added install_env(env) Jinja macro for per-environment install logic
Replaced single install block with loop over setup_envs

Checklist - did you ...

Add a file to the news directory (using the template) for the next release's release notes?
Add / update necessary tests?
Add / update outdated documentation?

lrandersson · 2026-03-20T14:57:05Z

 >> "%LOG%" echo {{ message }}
 {%- endmacro %}

+{% macro install_env(env) %}


I went with the macro approach because it seems easier to read, slightly.

lrandersson · 2026-03-25T17:53:17Z

        return os_allowed[osname][:1]
    elif itype == "all":
        return os_allowed[osname]
+    elif isinstance(itype, (list, tuple)):


This I added because when I first added msi to installer_types to the example outputs (further down), an uncaughted exception was raised.

lrandersson · 2026-03-25T17:55:03Z

 {{ tee("Running constructor uninstall...") }}
 "%CONDA_EXE%" constructor uninstall --prefix "%BASE_PATH%"!UNINST_ARGS! --log-file "%LOG%"
 if errorlevel 1 ( exit /b %errorlevel% )
-{%- else %}


Removed all of this because I enforced info["uninstall_with_conda_exe"] = True in briefcase.py.

lrandersson · 2026-03-25T17:56:18Z

                "title": "Create shortcuts",
                "description": "Create shortcuts (supported packages only).",
-                "default": False,
+                "default": True,


Now it matches NSIS.

marcoesters · 2026-03-26T18:22:36Z

+    # MSI installers always use conda-standalone for uninstallation.
+    # This ensures proper cleanup of conda init, environments, and shortcuts
+    # via the `conda constructor uninstall` command.
+    info["uninstall_with_conda_exe"] = True


It needs to be verified that the conda-standalone version supports this, or we need to bump the minimum required version for conda-standalone.

Hmm, do you have any preference on which approach would be the best here? I'm leaning towards bumping the minimum required version and take advantage of requiring all the new nice features.

What is the minimum version that we need to bump it to?

24.11.0 and I think this would be reasonable considering we have this already

constructor/constructor/main.py

Line 218 in 44ba181

exe_type == StandaloneExe.CONDA and check_version(exe_version, min_version="24.11.0")

That version check is for exactly that feature, but requiring at least 24.11.0 seems reasonable enough.

See e1911f5

marcoesters · 2026-03-26T18:23:36Z

+        dists = self.info["_dists"].copy()
+        for env_info in self.info.get("_extra_envs_info", {}).values():
+            dists += env_info["_dists"]
+        dists = list({dist: None for dist in dists})  # de-duplicate


Why not use a set instead?

We could definitely use a set here, but a dict here preserves the insertion order. The functionality is the same but for debugging purposes and reproducible builds/logs I'd say a dict provides with a slight advantage.

Does insertion order matter here?

For debugging or reproducible logs, I would find a sorted list (which you can get from a set) more useful and would make the code more legible/semantic.

Good idea, see ee96eec

Co-authored-by: Marco Esters <mesters@anaconda.com>

* add support for extra_envs, work in progress * Fix rebase issues * Add more examples to MSI testing * fix error: TypeError: unhashable type * Changed default value of shortcut option for consistency with NSIS * Add debug output * Always uninstall with conda-standalone * Add debug output * Improve debug output * Remove debug output, skip test * Remove more debug statements * Use pytest.xfail * Review fix * Add suggestion from review Co-authored-by: Marco Esters <mesters@anaconda.com> * Bump min conda-standalone --------- Co-authored-by: Marco Esters <mesters@anaconda.com>

conda-bot added this to 🔎 Review Mar 20, 2026

lrandersson changed the base branch from main to briefcase-integration March 20, 2026 14:56

github-project-automation Bot moved this to 🆕 New in 🔎 Review Mar 20, 2026

conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 20, 2026

lrandersson commented Mar 20, 2026

View reviewed changes

add support for extra_envs, work in progress

140fd41

lrandersson force-pushed the dev-ra-extra-envs branch from 9d1faba to 5f568a4 Compare March 24, 2026 13:09

lrandersson marked this pull request as ready for review March 24, 2026 13:09

lrandersson requested a review from a team as a code owner March 24, 2026 13:09

Fix rebase issues

c473440

lrandersson force-pushed the dev-ra-extra-envs branch from 5f568a4 to c473440 Compare March 24, 2026 13:15

lrandersson marked this pull request as draft March 24, 2026 13:17

lrandersson added 6 commits March 24, 2026 09:28

Add more examples to MSI testing

6a16b79

fix error: TypeError: unhashable type

2a94076

Changed default value of shortcut option for consistency with NSIS

f24d495

Add debug output

577ff02

Always uninstall with conda-standalone

d7dfc4f

Add debug output

c874317

lrandersson force-pushed the dev-ra-extra-envs branch from 652d53a to c874317 Compare March 25, 2026 13:14

lrandersson added 2 commits March 25, 2026 10:15

Improve debug output

2dd654e

Remove debug output, skip test

90c168a

lrandersson self-assigned this Mar 25, 2026

lrandersson commented Mar 25, 2026

View reviewed changes

Remove more debug statements

15f63c3

lrandersson commented Mar 25, 2026

View reviewed changes

lrandersson marked this pull request as ready for review March 25, 2026 17:56

Use pytest.xfail

431c17e

marcoesters reviewed Mar 26, 2026

View reviewed changes

lrandersson requested a review from marcoesters March 26, 2026 18:56

Review fix

ee96eec

marcoesters reviewed Mar 26, 2026

View reviewed changes

Comment thread constructor/briefcase.py Outdated

lrandersson and others added 2 commits March 27, 2026 08:29

Add suggestion from review

263bbe0

Co-authored-by: Marco Esters <mesters@anaconda.com>

Bump min conda-standalone

e1911f5

lrandersson requested a review from marcoesters March 27, 2026 12:39

marcoesters approved these changes Mar 27, 2026

View reviewed changes

github-project-automation Bot moved this from 🆕 New to ✅ Approved in 🔎 Review Mar 27, 2026

lrandersson merged commit 40cf913 into conda:briefcase-integration Mar 27, 2026
33 of 34 checks passed

github-project-automation Bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Mar 27, 2026

Conversation

lrandersson commented Mar 20, 2026

Description

Checklist - did you ...

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants