MSI: Add support for user supplied scripts#1189
Merged
lrandersson merged 7 commits intoApr 1, 2026
Merged
Conversation
5bdc044 to
45643fc
Compare
d5ebc52 to
a494224
Compare
lrandersson
commented
Mar 30, 2026
marcoesters
approved these changes
Mar 31, 2026
lrandersson
added a commit
that referenced
this pull request
Apr 7, 2026
* Add support for user supplied scripts * Enable some new examples * Fix type error for test * Change copying of extra_files to base environment * Fix issue with license file not being copied * Add debug output * Fix order of user script, fixes last error
lrandersson
added a commit
that referenced
this pull request
Apr 24, 2026
* Add support for user supplied scripts * Enable some new examples * Fix type error for test * Change copying of extra_files to base environment * Fix issue with license file not being copied * Add debug output * Fix order of user script, fixes last error
lrandersson
added a commit
that referenced
this pull request
May 1, 2026
* Add support for user supplied scripts * Enable some new examples * Fix type error for test * Change copying of extra_files to base environment * Fix issue with license file not being copied * Add debug output * Fix order of user script, fixes last error
lrandersson
added a commit
to lrandersson/constructor
that referenced
this pull request
May 28, 2026
* Add support for user supplied scripts * Enable some new examples * Fix type error for test * Change copying of extra_files to base environment * Fix issue with license file not being copied * Add debug output * Fix order of user script, fixes last error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for user-supplied pre_install, post_install, and pre_uninstall scripts in MSI installers, mirroring existing NSIS functionality.
A summary of the changes:
Script integration (
briefcase.py)base/pkgs/asuser_pre_install.bat,user_post_install.bat,user_pre_uninstall.batis_bat_file()before copyingTemplate Updates (
run_installation.bat,pre_uninstall.bat)INSTALLER_NAME,INSTALLER_VER,INSTALLER_PLAT,INSTALLER_TYPE=MSIINSTALLER_UNATTENDEDnot available (requires WiX template changes)Followed the same logic as explained in the schema (and NSIS):
*_descare optional (gated byOPTION_*_SCRIPTcheckbox)*_descare mandatoryDocumentation (
_schema.py)pre_uninstallandpost_installto document MSI supportChecklist - did you ...
newsdirectory (using the template) for the next release's release notes?