Fix TypeError when conda 26.x returns dict from fetch_latest()#1196
Open
gabrielbusta wants to merge 4 commits intoconda:mainfrom
Open
Fix TypeError when conda 26.x returns dict from fetch_latest()#1196gabrielbusta wants to merge 4 commits intoconda:mainfrom
gabrielbusta wants to merge 4 commits intoconda:mainfrom
Conversation
Contributor
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @gabrielbusta. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1308), and ping the bot to refresh the PR. |
marcoesters
reviewed
Apr 3, 2026
Contributor
marcoesters
left a comment
There was a problem hiding this comment.
Thank you! This looks good, but we need a news file to this PR as described in the checklist. Please also let me know CLA has been signed and I can get the bot CLA check to re-run.
In conda 26.x, `subdir_data.repo_fetch.fetch_latest()` returns an already-parsed dict instead of a JSON string. Add a type check to handle both cases, maintaining backward compatibility with older conda versions.
21205a8 to
7f42508
Compare
Co-authored-by: Marco Esters <mesters@anaconda.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi I ran into an issue running an installer build, and I think it is a constructor/conda compatibility issue:
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?