Skip to content

MSI: Set CONDA_QUIET and add new NSIS variables to MSI scripts. #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lrandersson merged 2 commits into from
Apr 7, 2026
+14 −0
Merged

MSI: Set CONDA_QUIET and add new NSIS variables to MSI scripts. #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
747fbaf
Set CONDA_QUIET
lrandersson Apr 6, 2026
3631f43
Add new uninstaller variables
lrandersson Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions constructor/briefcase/pre_uninstall.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ set "PREFIX=%BASE_PATH%"
set "CONDA_EXE=%INSTDIR%\{{ conda_exe_name }}"
set "PAYLOAD_TAR=%INSTDIR%\{{ archive_name }}"
set "CONDA_ROOT_PREFIX=%BASE_PATH%"
rem Set CONDA_QUIET primarily to disable the spinners
set CONDA_QUIET={{ 0 if add_debug else 1 }}

rem Get the name of the install directory
for %%I in ("%INSTDIR%") do set "APPNAME=%%~nxI"
Expand Down Expand Up @@ -53,6 +55,13 @@ if exist "%BASE_PATH%\.nonadmin" (
set "REG_HIVE=HKLM"
)

rem Map OPTION_* to UNINSTALLER_* for compatibility with NSIS uninstaller scripts
if "%OPTION_REMOVE_USER_DATA%"=="1" set "UNINSTALLER_REMOVE_USER_DATA=1"
if "%OPTION_REMOVE_CACHES%"=="1" set "UNINSTALLER_REMOVE_CACHES=1"
if "%OPTION_REMOVE_CONFIG_FILES%"=="1" (
if "%REG_HIVE%"=="HKCU" (set "UNINSTALLER_REMOVE_CONFIG_FILES=user") else (set "UNINSTALLER_REMOVE_CONFIG_FILES=all")
)

{%- if add_debug %}
>> "%LOG%" echo ==== pre_uninstall start ====
>> "%LOG%" echo SCRIPT=%~f0
Expand All @@ -67,6 +76,9 @@ if exist "%BASE_PATH%\.nonadmin" (
>> "%LOG%" echo OPTION_REMOVE_USER_DATA=%OPTION_REMOVE_USER_DATA%
>> "%LOG%" echo OPTION_REMOVE_CACHES=%OPTION_REMOVE_CACHES%
>> "%LOG%" echo OPTION_REMOVE_CONFIG_FILES=%OPTION_REMOVE_CONFIG_FILES%
>> "%LOG%" echo UNINSTALLER_REMOVE_USER_DATA=%UNINSTALLER_REMOVE_USER_DATA%
>> "%LOG%" echo UNINSTALLER_REMOVE_CACHES=%UNINSTALLER_REMOVE_CACHES%
>> "%LOG%" echo UNINSTALLER_REMOVE_CONFIG_FILES=%UNINSTALLER_REMOVE_CONFIG_FILES%
"%CONDA_EXE%" --version >> "%LOG%" 2>&1
{%- endif %}

Expand Down
2 changes: 2 additions & 0 deletions constructor/briefcase/run_installation.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ set CONDA_PROTECT_FROZEN_ENVS=0
set CONDA_REGISTER_ENVS={{ register_envs }}
set CONDA_SAFETY_CHECKS=disabled
set "CONDA_ROOT_PREFIX=%BASE_PATH%"
rem Set CONDA_QUIET primarily to disable the spinners
set CONDA_QUIET={{ 0 if add_debug else 1 }}

rem Get the name of the install directory
for %%I in ("%INSTDIR%") do set "APPNAME=%%~nxI"
Expand Down
Loading