Skip to content

MSI: Improve font usage for license text page#1246

Merged
lrandersson merged 2 commits into
conda:briefcase-integrationfrom
lrandersson:dev-ra-test-font-fix
May 27, 2026
Merged

MSI: Improve font usage for license text page#1246
lrandersson merged 2 commits into
conda:briefcase-integrationfrom
lrandersson:dev-ra-test-font-fix

Conversation

@lrandersson
Copy link
Copy Markdown
Contributor

Description

The MSI installer license text is by default displayed in Courier font because Briefcase's default txt_to_rtf() converter uses Courier with no font size specified. This PR adds a font handling to the license text if the file is not in rtf, making the displayed text prettier (and most importantly easier to read).

This branch is created from the same branch as #1241 so I put this in draft right now.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@lrandersson lrandersson self-assigned this May 26, 2026
@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review May 26, 2026
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 26, 2026
@lrandersson lrandersson changed the title Dev ra test font fix MSI: Improve font usage for license text page May 26, 2026
@lrandersson lrandersson force-pushed the dev-ra-test-font-fix branch from cb326b9 to 2fde247 Compare May 26, 2026 18:32
@lrandersson lrandersson marked this pull request as ready for review May 26, 2026 18:33
@lrandersson lrandersson requested a review from a team as a code owner May 26, 2026 18:33
@github-project-automation github-project-automation Bot moved this from 🆕 New to ✅ Approved in 🔎 Review May 26, 2026
@lrandersson lrandersson merged commit 930467d into conda:briefcase-integration May 27, 2026
33 of 34 checks passed
@github-project-automation github-project-automation Bot moved this from ✅ Approved to 🏁 Done in 🔎 Review May 27, 2026
lrandersson added a commit to lrandersson/constructor that referenced this pull request May 28, 2026
* Add function to modify text font

* Add tests and misc improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

3 participants