fix(redis): load Redis connection beans when Redis is used for queues#992
Merged
mp-orkes merged 2 commits intoApr 10, 2026
Merged
Conversation
mp-orkes
requested changes
Apr 8, 2026
Contributor
mp-orkes
left a comment
There was a problem hiding this comment.
@bulgarian-beast thank you! LGTM. Please rebase on top of main to fix the conflict with RedisSentinelConfiguration.java (caused by #951 landing after your branch point). Once done I'll approve and merge.
549201d to
17743b5
Compare
Contributor
Author
|
Hi @mp-orkes Rebased on top of main and resolved the RedisSentinelConfiguration.java conflict in 17743b5. Re-validated with:
Could you please re-review and approve when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #991
Summary
This fixes a startup regression where Conductor fails to boot when Redis is configured only as the queue backend, such as in the MySQL + Redis Docker Compose setup.
Root cause
Redis connection configuration classes were only activated when
conductor.db.typematched a Redis mode, but queue autoconfiguration also requires these beans whenconductor.queue.typeis set to Redis.Changes
Validation
./gradlew spotlessApply./gradlew :conductor-redis-configuration:test --tests com.netflix.conductor.redis.config.RedisConnectionConditionTestdocker compose -f docker/docker-compose-mysql.yaml up --build -dhttp://localhost:8000/healthreturns healthy