Skip to content

Conversation

@ArturSelitskiy-sm
Copy link
Contributor

@ArturSelitskiy-sm ArturSelitskiy-sm commented Oct 28, 2025

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

  • Added all supported roles to UpsertUserRequest and UpsertGroupRequest.
  • User validation now blocks app: IDs and enforces USER_READ_ONLY exclusivity.
  • Group validation keeps USER_READ_ONLY isolated and checks defaultAccess keys via RoleValidation.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...onductor/client/http/OrkesAuthorizationClient.java 0.00% 27 Missing ⚠️
...io/orkes/conductor/client/util/RoleValidation.java 0.00% 10 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...io/orkes/conductor/client/util/RoleValidation.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...onductor/client/http/OrkesAuthorizationClient.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArturSelitskiy-sm ArturSelitskiy-sm marked this pull request as ready for review October 28, 2025 16:14
@ArturSelitskiy-sm ArturSelitskiy-sm merged commit f54b8e8 into main Oct 30, 2025
2 of 3 checks passed
@ArturSelitskiy-sm ArturSelitskiy-sm deleted the roles-validation branch October 30, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants