Skip to content

readme-update: removed agentOptions#28

Merged
v1r3n merged 3 commits intomainfrom
readme-update
Apr 11, 2023
Merged

readme-update: removed agentOptions#28
v1r3n merged 3 commits intomainfrom
readme-update

Conversation

@najeebkp
Copy link
Copy Markdown
Collaborator

@najeebkp najeebkp commented Apr 6, 2023

  • removed the following snippet from readme.md
const agentOptions = {
  key: "<buffer>",
  cert: "<buffer>",
  ca: "<buffer>",
  servername: 'play.orkes.io',
  // ...
}

@najeebkp najeebkp requested a review from Sudakatux April 6, 2023 11:54
Comment thread README.md Outdated
@@ -24,20 +24,10 @@ const client = new ConductorClient({
The client uses `node-fetch` which supports node.js's [`httpsAgent` options](https://nodejs.org/api/https.html#new-agentoptions). For example:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title description of the code you removed should go too

Copy link
Copy Markdown
Collaborator Author

@najeebkp najeebkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example tested.
LGTM.

@v1r3n v1r3n merged commit 92db185 into main Apr 11, 2023
@v1r3n v1r3n deleted the readme-update branch April 11, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants