Skip to content

fix: Calls with double / #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gardusig merged 1 commit into from
May 10, 2023
+7 −7
Merged

fix: Calls with double / #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/conductor/client/configuration/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def __init__(
if server_api_url != None:
self.host = server_api_url
else:
self.host = base_url + '/api/'
self.host = base_url + '/api'

self.temp_folder_path = None

Expand Down
12 changes: 6 additions & 6 deletions tests/unit/test_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def test_initialization_default(self):
configuration = Configuration()
self.assertEqual(
configuration.host,
'http://localhost:8080/api/'
'http://localhost:8080/api'
)

def test_initialization_with_base_url(self):
Expand All @@ -18,24 +18,24 @@ def test_initialization_with_base_url(self):
)
self.assertEqual(
configuration.host,
'https://play.orkes.io/api/'
'https://play.orkes.io/api'
)

def test_initialization_with_server_api_url(self):
configuration = Configuration(
server_api_url='https://play.orkes.io/api/'
server_api_url='https://play.orkes.io/api'
)
self.assertEqual(
configuration.host,
'https://play.orkes.io/api/'
'https://play.orkes.io/api'
)

def test_initialization_with_basic_auth_server_api_url(self):
configuration = Configuration(
server_api_url="https://user:password@play.orkes.io/api/"
server_api_url="https://user:password@play.orkes.io/api"
)
basic_auth = "user:password"
expected_host = f"https://{basic_auth}@play.orkes.io/api/"
expected_host = f"https://{basic_auth}@play.orkes.io/api"
self.assertEqual(
configuration.host, expected_host,
)
Expand Down