Skip to content

Conversation

@IgorChvyrov-sm
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ctor/asyncio_client/adapters/api_client_adapter.py 95.65% 1 Missing ⚠️
Files with missing lines Coverage Δ
...ctor/asyncio_client/configuration/configuration.py 100.00% <100.00%> (ø)
...ctor/asyncio_client/adapters/api_client_adapter.py 98.73% <95.65%> (ø)

... and 447 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@nthmost-orkes nthmost-orkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward, agreed that broad locking is the right move to prevent network overhead.

Could you add a nice explanatory comment to that section of the code to annotate that the broad lock is there for that purpose? Just to reduce head-scratching in the future!

@IgorChvyrov-sm
Copy link
Contributor Author

Looks straightforward, agreed that broad locking is the right move to prevent network overhead.

Could you add a nice explanatory comment to that section of the code to annotate that the broad lock is there for that purpose? Just to reduce head-scratching in the future!

Sure thing, done

Copy link

@nthmost-orkes nthmost-orkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks @IgorChvyrov-sm !

# Conflicts:
#	src/conductor/asyncio_client/adapters/api_client_adapter.py
#	src/conductor/asyncio_client/configuration/configuration.py
@IgorChvyrov-sm IgorChvyrov-sm merged commit 64e7763 into main Sep 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants