-
Notifications
You must be signed in to change notification settings - Fork 38
Prevent race condition during JWT obtaining #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
... and 447 files with indirect coverage changes 🚀 New features to boost your workflow:
|
nthmost-orkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward, agreed that broad locking is the right move to prevent network overhead.
Could you add a nice explanatory comment to that section of the code to annotate that the broad lock is there for that purpose? Just to reduce head-scratching in the future!
Sure thing, done |
nthmost-orkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Thanks @IgorChvyrov-sm !
# Conflicts: # src/conductor/asyncio_client/adapters/api_client_adapter.py # src/conductor/asyncio_client/configuration/configuration.py
No description provided.