add move construct for double link list#100
Merged
Merged
Conversation
74367aa to
f1f7a8d
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the intrusive container utilities by adding move support for IntrusiveDoubleList, and extends the unit tests to validate basic move behavior.
Changes:
- Add move constructor and move-assignment operator to
IntrusiveDoubleList. - Remove debug-only ownership tracking from
DoubleLinkEntryand related assertions. - Add a new doctest covering move-assignment of a double intrusive list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
include/condy/intrusive.hpp |
Adds move operations for IntrusiveDoubleList and removes debug ownership checks from double-link entries. |
tests/test_intrusive.cpp |
Adds a new test case for IntrusiveDoubleList move behavior. |
Comments suppressed due to low confidence (1)
include/condy/intrusive.hpp:110
- The PR removes the
DoubleLinkEntry::ownerdebug field and the associated ownership assertions inpush_back/pop_front/remove. That weakens debug-mode detection of cross-list misuse (e.g., callingremove()with an item belonging to a different list), which can silently corrupt lists. If move support is the motivation, consider keepingownerunder#ifndef NDEBUGand updating it during move (O(n) but debug-only), or otherwise retaining an equivalent debug membership check.
void push_back(T *item) noexcept {
assert(item != nullptr);
DoubleLinkEntry *entry = &(item->*Member);
assert(entry->next == nullptr && entry->prev == nullptr);
entry->next = nullptr;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f1f7a8d to
ca4ddca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.