refactor Ring class#110
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors condy::Ring toward RAII construction (constructor initializes; destructor exits) and moves ring-adjacent helpers (FdTable, BufferTable, RingSettings) out of Ring/into runtime-owned components, updating tests to the new APIs.
Changes:
- Replace
Ring::init()/Ring::destroy()usage withRing(entries, params)construction across tests. - Make
RuntimeownFdTable,BufferTable, andRingSettingsinstead of delegating throughRing. - Extract
FdTable/BufferTable/RingSettingsinto a newinclude/condy/ring_settings.hppheader.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_ring.cpp | Update tests to construct Ring directly (no init/destroy calls). |
| tests/test_op_finish_handle.cpp | Update ring creation to new constructor-based API. |
| tests/test_fd_table.cpp | Switch table access from Context::ring() to Context::runtime(). |
| tests/test_buffers.cpp | Update ring creation to new constructor-based API. |
| tests/test_buffer_table.cpp | Switch table access to runtime-owned tables; update clone test setup. |
| include/condy/runtime.hpp | Refactor runtime ring construction; move tables/settings to runtime members; adjust thread-local ring creation. |
| include/condy/ring.hpp | Remove init/destroy pattern; add throwing constructor + RAII teardown; update SQPOLL checks. |
| include/condy/ring_settings.hpp | New header containing FdTable, BufferTable, and RingSettings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.