Skip to content

fix bundle + incr provided buffers#115

Merged
wokron merged 3 commits into
masterfrom
fix-bundle-incr
May 16, 2026
Merged

fix bundle + incr provided buffers#115
wokron merged 3 commits into
masterfrom
fix-bundle-incr

Conversation

@wokron
Copy link
Copy Markdown
Member

@wokron wokron commented May 15, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts bundled provided buffer handling for incremental buffer rings, aligning queue/pool bookkeeping with partial buffer consumption behavior.

Changes:

  • Tracks buffer ring registration flags in provided buffer queue/pool internals.
  • Updates bundled incremental completion handling to distinguish fully consumed buffers from partial tails.
  • Expands tests for bundled incremental queue/pool behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
include/condy/provided_buffers.hpp Updates bundled provided buffer queue/pool state handling for incremental buffer rings.
tests/test_buffers.cpp Adjusts unit expectations for bundled incremental queue/pool consumption.
tests/test_async_operations.1.cpp Adds async coverage for subsequent bundled incremental receives and partial-tail behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/condy/provided_buffers.hpp
Comment thread tests/test_async_operations.1.cpp
@wokron wokron force-pushed the fix-bundle-incr branch from e67e76a to e22fd40 Compare May 15, 2026 14:58
@wokron wokron marked this pull request as ready for review May 16, 2026 02:34
@wokron wokron merged commit 46909b5 into master May 16, 2026
13 checks passed
@wokron wokron deleted the fix-bundle-incr branch May 16, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants