update canceller#117
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the canceller interface used by ParallelOperationState and RangedParallelOperationState: the two-method API (maybe_request_stop / maybe_reset) is collapsed into a templated operator()(const R&) plus reset(). This sets up a more flexible canceller that can inspect the per-child result (useful for future predicate-based cancellation), while keeping current WhenAny/WhenAll semantics unchanged.
Changes:
- Replace
maybe_request_stop()withtemplate <typename R> operator()(const R&)on bothWhenAnyCancellerandWhenAllCanceller. - Rename
maybe_reset()toreset(). - Update call sites in
ParallelOperationState::receive_andRangedParallelOperationState::receive_accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.