Skip to content

new op awaiter construct api#41

Merged
wokron merged 5 commits into
masterfrom
build-op-awaiter-api
Feb 12, 2026
Merged

new op awaiter construct api#41
wokron merged 5 commits into
masterfrom
build-op-awaiter-api

Conversation

@wokron
Copy link
Copy Markdown
Member

@wokron wokron commented Feb 12, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors how io_uring operation awaiters are constructed by introducing new build_*_op_awaiter helpers and relocating the existing make_* factory helpers under condy::detail, updating library code and tests accordingly.

Changes:

  • Add build_op_awaiter, build_multishot_op_awaiter, and build_zero_copy_op_awaiter templates to centralize awaiter construction.
  • Move make_op_awaiter / make_multishot_* / make_zero_copy_* helpers into condy::detail and update call sites across the library.
  • Update tests to use condy::detail::make_* factories.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
include/condy/awaiter_operations.hpp Introduces new build_* awaiter constructors and moves make_* helpers into condy::detail.
include/condy/async_operations.hpp Updates async wrappers to call detail::make_* factories.
tests/test_task.cpp Updates test awaiter creation to condy::detail::make_op_awaiter.
tests/test_runtime.cpp Updates runtime tests to use condy::detail::make_op_awaiter.
tests/test_op_awaiter.cpp Updates op_awaiter tests to use condy::detail::make_* factories.
tests/test_fd_table.cpp Updates fixed-fd tests to use condy::detail::make_op_awaiter.
tests/test_buffer_table.cpp Updates registered-buffer tests to use condy::detail::make_op_awaiter.
tests/test_awaiter_operations.cpp Updates awaiter operations tests to use condy::detail::make_op_awaiter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/condy/awaiter_operations.hpp
Comment thread include/condy/awaiter_operations.hpp
@wokron wokron merged commit 6b95ffd into master Feb 12, 2026
11 checks passed
@wokron wokron deleted the build-op-awaiter-api branch February 12, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants