support async_uring_cmd#42
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for liburing’s IORING_OP_URING_CMD via new condy::async_uring_cmd and condy::async_uring_cmd128 wrappers, along with tests to validate basic and fixed-fd usage (including SQE128/mixed-ring configuration).
Changes:
- Add
async_uring_cmdandasync_uring_cmd128awaitable wrappers (guarded for liburing >= 2.13). - Extend async-operations test suite with new
uring_cmd/uring_cmd128test cases (basic + fixed-fd) and required runtime options setup. - Minor formatting cleanups in existing tests (uniform brace-init style).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/test_async_operations.4.cpp | Adds test coverage for async_uring_cmd / async_uring_cmd128 (basic + fixed-fd), plus minor formatting tweaks and runtime-options usage for SQE128/mixed. |
| include/condy/async_operations.hpp | Introduces the new async_uring_cmd and async_uring_cmd128 APIs and wires them into existing awaiter construction patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wokron
force-pushed
the
support-uring-cmd-new
branch
from
2869262 to
24f23e8
Compare
wokron
force-pushed
the
support-uring-cmd-new
branch
from
24f23e8 to
048643d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.