support tx timestamp#46
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for receiving socket TX timestamps via io_uring by introducing a multishot uring_cmd async operation and a dedicated CQE handler, along with documentation and a new test to validate the behavior.
Changes:
- Add
condy::async_uring_cmd_multishot()to support multishotIORING_OP_URING_CMDworkflows. - Introduce
TxTimestampResult/TxTimestampCQEHandlerfor parsing TX timestamp CQE32 payloads. - Add a Linux socket-based test case covering TX timestamp events and update ops documentation to list the new API.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_async_operations.4.cpp | Adds a new test exercising multishot uring_cmd TX timestamp collection. |
| include/condy/cqe_handler.hpp | Adds a shared CQE32-check helper and a TX timestamp CQE handler/result struct. |
| include/condy/async_operations.hpp | Introduces async_uring_cmd_multishot() API wrapper. |
| docs/ops.md | Documents the new multishot uring_cmd operation in the ops list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.