support get_sqe128() and async_nop128()#7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for 128-bit submission queue entries (SQE128) in io_uring, including the get_sqe128() method and async_nop128() operation. The changes are conditionally compiled for liburing versions >= 2.13.
Key Changes:
- Added template-based
get_sqe_()method to support both standard and 128-bit SQE retrieval - Introduced
OpAwaiter128class andmake_op_awaiter128()helper for SQE128-specific operations - Added
async_nop128()operation with corresponding test case
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| include/condy/ring.hpp | Refactored get_sqe() into a templated get_sqe_() method and added get_sqe128() wrapper for liburing >= 2.13 |
| include/condy/awaiters.hpp | Added SQE128 template parameter to OpAwaiterBase, created OpAwaiter128 class, and modified version check for DRAIN workaround |
| include/condy/awaiter_operations.hpp | Added make_op_awaiter128() helper function for creating SQE128 awaiters |
| include/condy/async_operations.hpp | Added async_nop128() operation for liburing >= 2.13 |
| tests/test_async_operations.cpp | Added test case for async_nop128() functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e0d9a91 to
9857d92
Compare
9857d92 to
51dcab6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
51dcab6 to
afb7129
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for linux 6.19