Skip to content

support get_sqe128() and async_nop128()#7

Merged
wokron merged 2 commits into
masterfrom
support-sqe128
Feb 9, 2026
Merged

support get_sqe128() and async_nop128()#7
wokron merged 2 commits into
masterfrom
support-sqe128

Conversation

@wokron
Copy link
Copy Markdown
Member

@wokron wokron commented Jan 9, 2026

for linux 6.19

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for 128-bit submission queue entries (SQE128) in io_uring, including the get_sqe128() method and async_nop128() operation. The changes are conditionally compiled for liburing versions >= 2.13.

Key Changes:

  • Added template-based get_sqe_() method to support both standard and 128-bit SQE retrieval
  • Introduced OpAwaiter128 class and make_op_awaiter128() helper for SQE128-specific operations
  • Added async_nop128() operation with corresponding test case

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
include/condy/ring.hpp Refactored get_sqe() into a templated get_sqe_() method and added get_sqe128() wrapper for liburing >= 2.13
include/condy/awaiters.hpp Added SQE128 template parameter to OpAwaiterBase, created OpAwaiter128 class, and modified version check for DRAIN workaround
include/condy/awaiter_operations.hpp Added make_op_awaiter128() helper function for creating SQE128 awaiters
include/condy/async_operations.hpp Added async_nop128() operation for liburing >= 2.13
tests/test_async_operations.cpp Added test case for async_nop128() functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/condy/awaiters.hpp Outdated
Comment thread include/condy/awaiters.hpp Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/condy/ring.hpp Outdated
@wokron wokron merged commit 006bbb1 into master Feb 9, 2026
11 checks passed
@wokron wokron deleted the support-sqe128 branch February 9, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants