remove BundledBufferRing concept#73
Merged
Merged
Conversation
wokron
force-pushed
the
remove-provided-buffer-concept
branch
from
25512b1 to
b698755
Compare
wokron
force-pushed
the
remove-provided-buffer-concept
branch
from
b698755 to
d1af311
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the BundledBufferRing / NotBundledBufferRing concepts and updates async operation overload constraints accordingly, introducing a reusable AnySameAs concept to express “one-of” type constraints.
Changes:
- Delete
BundledBufferRing/NotBundledBufferRingconcepts fromconcepts.hpp. - Add
AnySameAsconcept and replace severalNotBundledBufferRing/BundledBufferRingconstraints inasync_operations.hpp. - Move bundled provided-buffer forward declarations to
async_operations.hpp(incondy::detail).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| include/condy/concepts.hpp | Removes bundled buffer ring concepts; adds AnySameAs. |
| include/condy/async_operations.hpp | Updates async op template constraints to use AnySameAs and adds bundled-type forward declarations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.