update RawStorage related code#85
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates condy::RawStorage to support in-place construction via a factory (enabling guaranteed copy elision for non-movable/non-copyable types), modernizes object access with std::launder, and adjusts tests and coroutine allocator cleanup to match the updated storage/lifetime patterns.
Changes:
- Add
RawStorage::accept(Factory)and re-routeconstruct(...)through it to enable guaranteed copy elision scenarios. - Use
std::launderwhen retrieving objects from raw storage, and similarly launder the allocator pointer in coroutine deallocation. - Extend unit tests to cover a non-movable/non-copyable type construction path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_utils.cpp | Updates RawStorage test usage and adds a guaranteed copy-elision test case. |
| include/condy/utils.hpp | Introduces RawStorage::accept, updates construct, and changes get() to use std::launder. |
| include/condy/coro.inl | Adds <new> and uses std::launder when accessing the stored allocator during coroutine deallocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.