Skip to content

simplify CQE handler#92

Merged
wokron merged 5 commits into
masterfrom
simplify-cqe-handler
Apr 18, 2026
Merged

simplify CQE handler#92
wokron merged 5 commits into
masterfrom
simplify-cqe-handler

Conversation

@wokron
Copy link
Copy Markdown
Member

@wokron wokron commented Apr 18, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors CQE handler integration to simplify completion processing by switching CQE handlers from a stateful handle_cqe/extract_result API to a callable operator()(io_uring_cqe*) -> result API.

Changes:

  • Reworked CQE handlers to return results directly via operator().
  • Updated OpSender/OpFinishHandle plumbing to store and invoke CQE handlers directly (no tuple-stored handler args).
  • Updated tests to construct handles with an explicit CQE handler instance.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
tests/test_ring.cpp Updates handle construction to pass a CQE handler instance.
tests/test_op_finish_handle.cpp Updates finish-handle constructions to pass a CQE handler instance.
include/condy/senders.hpp Simplifies sender types to store a CQE handler instance and deduce ReturnType from invocation.
include/condy/sender_operations.hpp Updates builder helpers to construct CQE handler instances up-front.
include/condy/op_states.hpp Simplifies operation state ctor to forward handle args directly.
include/condy/finish_handles.hpp Updates finish handles to invoke CQE handlers via operator() and pass results directly to receivers.
include/condy/cqe_handler.hpp Rewrites CQE handlers to implement operator() returning the completion result.
include/condy/concepts.hpp Updates CQEHandlerLike concept to require only callability via handler(cqe).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/condy/senders.hpp
Comment thread include/condy/senders.hpp
Comment thread include/condy/senders.hpp
Comment thread include/condy/finish_handles.hpp Outdated
Comment thread include/condy/concepts.hpp Outdated
Comment thread tests/test_ring.cpp Outdated
Comment thread tests/test_ring.cpp
Comment thread tests/test_op_finish_handle.cpp Outdated
@wokron wokron force-pushed the simplify-cqe-handler branch from ae26edc to c616ddc Compare April 18, 2026 09:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/condy/sender_operations.hpp
Comment thread include/condy/sender_operations.hpp
Comment thread include/condy/sender_operations.hpp
Comment thread include/condy/cqe_handler.hpp Outdated
Comment thread include/condy/concepts.hpp
@wokron wokron force-pushed the simplify-cqe-handler branch from 36e0e4f to 10885dc Compare April 18, 2026 11:43
@wokron wokron marked this pull request as ready for review April 18, 2026 11:47
@wokron wokron merged commit b50d380 into master Apr 18, 2026
11 checks passed
@wokron wokron deleted the simplify-cqe-handler branch April 18, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants