simplify CQE handler#92
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors CQE handler integration to simplify completion processing by switching CQE handlers from a stateful handle_cqe/extract_result API to a callable operator()(io_uring_cqe*) -> result API.
Changes:
- Reworked CQE handlers to return results directly via
operator(). - Updated
OpSender/OpFinishHandleplumbing to store and invoke CQE handlers directly (no tuple-stored handler args). - Updated tests to construct handles with an explicit CQE handler instance.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_ring.cpp | Updates handle construction to pass a CQE handler instance. |
| tests/test_op_finish_handle.cpp | Updates finish-handle constructions to pass a CQE handler instance. |
| include/condy/senders.hpp | Simplifies sender types to store a CQE handler instance and deduce ReturnType from invocation. |
| include/condy/sender_operations.hpp | Updates builder helpers to construct CQE handler instances up-front. |
| include/condy/op_states.hpp | Simplifies operation state ctor to forward handle args directly. |
| include/condy/finish_handles.hpp | Updates finish handles to invoke CQE handlers via operator() and pass results directly to receivers. |
| include/condy/cqe_handler.hpp | Rewrites CQE handlers to implement operator() returning the completion result. |
| include/condy/concepts.hpp | Updates CQEHandlerLike concept to require only callability via handler(cqe). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ae26edc to
c616ddc
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
36e0e4f to
10885dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.