support async futex#99
Merged
Merged
Conversation
Closed
There was a problem hiding this comment.
Pull request overview
This PR introduces a coroutine-friendly futex primitive (condy::Futex) and adds corresponding tests and an example demonstrating a producer/consumer queue built on top of it.
Changes:
- Add
include/condy/futex.hppimplementingcondy::Futex<T>with asyncwait()and thread-safenotify_one/notify_all. - Add doctest coverage for async futex behaviors (basic notify, notify-all, cross-thread wake, cancellation, and a queue built from futex-based primitives).
- Add a new
queueexample and document/build it; exportfutex.hppfromcondy.hpp.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
include/condy/futex.hpp |
New futex implementation and sender-based wait API. |
tests/test_futex.cpp |
New doctest suite validating condy::Futex behavior and showcasing a futex-based queue. |
include/condy.hpp |
Exports condy/futex.hpp from the umbrella header. |
examples/queue.cpp |
Adds a futex-based producer/consumer queue example using two runtimes. |
examples/CMakeLists.txt |
Builds the new queue example; fixes formatting for futex-semaphore link line. |
docs/examples.md |
Documents the new queue.cpp example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bb004e2 to
1d00f09
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8d94d9a to
958315d
Compare
958315d to
14b5759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.