examples: add lift-upstream proof bundle#87
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 592999a850
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-data-redis</artifactId> |
There was a problem hiding this comment.
The bundle adds spring-boot-starter-data-redis, but upstream/app/src/main/java/com/example/inventory/InventoryApiApplication.java still never enables caching and upstream/app/src/main/java/com/example/inventory/api/InventoryService.java has no cached methods. In the current example, applying this advertised “GitHub-ready” patch only changes the reported CACHE_BACKEND value in InventoryController; it does not introduce any actual Redis-backed caching for the service.
Useful? React with 👍 / 👎.
| cache: | ||
| type: redis |
There was a problem hiding this comment.
Setting spring.cache.type to redis here selects Redis-backed cache behavior, but I could not find any Redis host/port/secret or Redis resource anywhere under incubator/springboot-platform-app—the only Redis-related additions are type: redis and CACHE_BACKEND=redis. That means any environment that actually exercises the cache has no way to reach a Redis instance, so this patch bundle is incomplete for the requested feature.
Useful? React with 👍 / 👎.
Add the remaining two routed-outcome proof bundles for the springboot-platform-app example: - lift-upstream: read-only Redis caching request bundle with render-diff, explain, and verify scripts - block-escalate: read-only datasource override boundary bundle with render-attempt, explain, and verify scripts Both bundles are deterministic and read-only. They prove the three-outcome mutation model without requiring a live cluster or real GitHub PR automation. Replaces PRs #87 and #89 which were stacked on intermediate branches that no longer exist after squash merges. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add the remaining two routed-outcome proof bundles for the springboot-platform-app example: - lift-upstream: read-only Redis caching request bundle with render-diff, explain, and verify scripts - block-escalate: read-only datasource override boundary bundle with render-attempt, explain, and verify scripts Both bundles are deterministic and read-only. They prove the three-outcome mutation model without requiring a live cluster or real GitHub PR automation. Replaces PRs #87 and #89 which were stacked on intermediate branches that no longer exist after squash merges. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 participant
Summary
springboot-platform-appValidation
./scripts/verify.shcd incubator/springboot-platform-app && ./verify.shcd incubator/springboot-platform-app && ./lift-upstream-verify.shcd incubator/springboot-platform-app/upstream/app && mvn testNotes