Merged
Conversation
Miles Todzo (mtodzo)
force-pushed
the
main
branch
from
ac4ed44 to
9d520ed
Compare
David Hyde (DABH)
approved these changes
May 6, 2022
Contributor
David Hyde (DABH)
left a comment
David Hyde (DABH)
left a comment
There was a problem hiding this comment.
LGTM once tests are there; only one trivial question
| github.com/confluentinc/ccloud-sdk-go-v2/iam v0.6.0 | ||
| github.com/confluentinc/ccloud-sdk-go-v2/org v0.5.0 | ||
| github.com/confluentinc/ccloud-sdk-go-v2/service-quota v0.1.0 | ||
| github.com/confluentinc/cire-bucket-service/protos/bucket v0.50.0 |
Contributor
There was a problem hiding this comment.
Is this public or private? Would like to not introduce new private dependencies
There was a problem hiding this comment.
Just investigated, and this was incorrectly marked as "indirect" earlier. I must've forgot to go mod tidy because it was in the wrong section.
Contributor
There was a problem hiding this comment.
Ok well regardless... is there any (relatively easy) way to eliminate this dependency? 😅 If we need to save that for another PR, no worries...
There was a problem hiding this comment.
Oh wait, this needed to be added for the BYOK Kafka integration test. So looks like we need it.
MuweiHe
reviewed
Jun 8, 2022
MuweiHe
reviewed
Jun 8, 2022
MuweiHe
reviewed
Jun 8, 2022
David Hyde (DABH)
approved these changes
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Added a wrapper around the CLI to collect usage data, with a special case for
--helpwhich does not call thePostRunfunction. (I'm using thePostRunhere since thePreRunis overly complex and needs a major refactor).Added a new make target,
update-whitelist, which makes a PR to the cc-cli-service with the whitelist for the next version.Example PR: https://github.com/confluentinc/cc-cli-service/pull/40