Skip to content

Set up Semaphore CI#1262

Merged
Brian Strauch (brianstrauch) merged 135 commits intomainfrom
semaphore
Sep 1, 2022
Merged

Set up Semaphore CI#1262
Brian Strauch (brianstrauch) merged 135 commits intomainfrom
semaphore

Conversation

@brianstrauch
Copy link

@brianstrauch Brian Strauch (brianstrauch) commented Apr 15, 2022

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
    • yes: ok

What

Use Semaphore CI instead of Azure Pipelines! With the help of caching, total time is < 10min (as opposed to ~30min with the current system)

TODOs:

@DABH
Copy link
Contributor

Brian Strauch (@brianstrauch) What is the latest on this? Wondering if it makes sense to migrate to Semaphore e.g. this week.

Also, since CPD in theory is using prod versions of services now, maybe it's a bit more stable, maybe we should try not skipping the system tests pipeline step for now, and/or trying to run system tests from semaphore? wdyt? Can always just skip it again if it's still flaky

@brianstrauch
Copy link
Author

I've been working on this on-and-off. There's still a bit more to do (see the TODO list above), and I'm not sure if we have Windows support yet... and yes! I would love to have Semaphore run our system tests too.

@brianstrauch Brian Strauch (brianstrauch) marked this pull request as ready for review August 24, 2022 23:08
@brianstrauch Brian Strauch (brianstrauch) requested a review from a team as a code owner August 24, 2022 23:08
- test-results publish . -N "darwin/amd64"
- rm *.xml

# - name: windows/amd64

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@DABH David Hyde (DABH) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM up to couple questions/comments

@@ -1,142 +0,0 @@
jobs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to kill this? Why not keep it until we migrate this to sem as well?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been disabled for almost a whole year, so I thought we would want to start from scratch, but sure, I suppose I can add it back just in case.

ls "${tmpdir}" | grep -q "LICENSE" || ( echo "License file not found" && exit 1 )
[[ "$(ls "${tmpdir}/legal/licenses" | wc -l)" -ge 20 ]] || ( echo "Appears to be missing some licenses; found less than 20 in the tmp dir" && exit 1 )

rm ~/.confluent/config.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why??

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added as a hack to fix a weird panic(). That's been fixed, so it should be fine to remove it. We're just running confluent -h here so there should be no reason that the contents of the config file change the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants