[DGS-3689] AsyncAPI Spec Generation for Confluent by pagrawal10 · Pull Request #1293 · confluentinc/cli

Parth Agrawal (pagrawal10) · 2022-05-25T05:12:39Z

Checklist

[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
Its a new feature, not a change in existing commands.

What

I have added AsyncAPI functionality to Confluent Cloud.
AsyncAPI One Pager
Intern Project Proposal

References

DGS-3096

Test & Review

Integration Tests have been added.

Brian Strauch (brianstrauch) · 2022-06-07T18:02:35Z

Parth Agrawal (@pagrawal10) looks like I don't have access to the 1-pager you've linked. I'm seeing:

You've stumbled on restricted content
This is because it's inheriting restrictions from a parent page. A space admin or the person who shared this page may be able to give you access.

Parth Agrawal (pagrawal10) · 2022-06-07T18:45:44Z

Brian Strauch (@brianstrauch) It should be accessible now.

asyncapi-spec.yaml

internal/cmd/asyncapi/command.go

internal/cmd/asyncapi/command_export.go

test/test-server/utils.go

internal/cmd/asyncapi/command.go

internal/cmd/asyncapi/command_export.go

internal/cmd/asyncapi/command.go

internal/cmd/asyncapi/command_export.go

internal/cmd/asyncapi/command.go

internal/cmd/asyncapi/command_export.go

internal/cmd/command.go

cmd/lint/main.go

internal/cmd/asyncapi/command_export.go

test/test-server/sr_handlers.go

internal/cmd/asyncapi/command_export.go

internal/cmd/asyncapi/account_details.go

internal/cmd/asyncapi/command_export.go

internal/cmd/asyncapi/command_export_test.go

internal/cmd/asyncapi/account_details.go

internal/cmd/asyncapi/command_export.go

internal/cmd/asyncapi/account_details.go

internal/cmd/asyncapi/command_export.go

Brian Strauch (brianstrauch)

Thank you for the changes!

internal/cmd/asyncapi/account_details.go

AsyncAPI Functionality added.

9f141a0

Brian Strauch (brianstrauch) changed the title ~~DGS-3689 - AsyncAPI Spec Generation for Confluent~~ [DGS-3689] AsyncAPI Spec Generation for Confluent May 25, 2022

Parth Agrawal (pagrawal10) added 6 commits May 31, 2022 10:00

AsyncAPI Functionality: Changes in TestHelp golden

af3eb30

Require Cloud Login for AsyncAPI

0057364

debugging for asyncapi test

8f8fa88

Changes in AsyncAPI Test

63b439a

Debugging AsyncAPI Test

bed7b89

Debugging AsyncAPI Test. Removed \r

582c5b1

Parth Agrawal (pagrawal10) marked this pull request as ready for review June 7, 2022 09:03

Parth Agrawal (pagrawal10) requested a review from a team as a code owner June 7, 2022 09:03

Brian Strauch (brianstrauch) suggested changes Jun 7, 2022

View reviewed changes

Parth Agrawal (pagrawal10) added 3 commits June 8, 2022 16:45

export function broken into smaller functions

8bdcde9

deleted yaml files generated during testing

180ab33

Updated golden file for Windows for TestHelp_Cloud

84da5f7

Parth Agrawal (pagrawal10) requested a review from Brian Strauch (brianstrauch) June 13, 2022 04:02

Brian Strauch (brianstrauch) suggested changes Jun 13, 2022

View reviewed changes

Parth Agrawal (pagrawal10) added 2 commits June 14, 2022 13:09

minor changes based on comments

0d50d3a

deleted yaml files

1900af2

Parth Agrawal (pagrawal10) requested a review from Brian Strauch (brianstrauch) June 14, 2022 09:51

Brian Strauch (brianstrauch) suggested changes Jun 14, 2022

View reviewed changes

Parth Agrawal (pagrawal10) added 2 commits June 15, 2022 00:27

Backend calls separated.

5746756

changed str to strings

5224282

Parth Agrawal (pagrawal10) requested a review from Brian Strauch (brianstrauch) June 14, 2022 19:33

Brian Strauch (brianstrauch) reviewed Jun 14, 2022

View reviewed changes

Parth Agrawal (pagrawal10) added 2 commits June 15, 2022 10:47

changes as per PR comments

f392be0

minor changes in asyncapi test

a191942

Parth Agrawal (pagrawal10) requested a review from Brian Strauch (brianstrauch) June 15, 2022 07:16

Brian Strauch (brianstrauch) reviewed Jun 15, 2022

View reviewed changes

Brian Strauch (brianstrauch) approved these changes Sep 26, 2022

View reviewed changes

added functionality to get topic description

dade30d

Brian Strauch (brianstrauch) suggested changes Sep 27, 2022

View reviewed changes

corrected error message for getTopicDescription

97aad2f

Parth Agrawal (pagrawal10) requested a review from Brian Strauch (brianstrauch) September 28, 2022 04:04

Brian Strauch (brianstrauch) reviewed Sep 28, 2022

View reviewed changes

internal/cmd/asyncapi/account_details.go Show resolved Hide resolved

internal/cmd/asyncapi/command_export.go Show resolved Hide resolved

Parth Agrawal (pagrawal10) and others added 3 commits September 30, 2022 12:04

improved error message for tags

8b9ccc8

changed error handling in account_details.go

99c9045

Merge branch 'main' into AsyncAPI

819879e

Brian Strauch (brianstrauch) reviewed Sep 30, 2022

View reviewed changes

internal/cmd/asyncapi/account_details.go Outdated Show resolved Hide resolved

internal/cmd/asyncapi/account_details.go Outdated Show resolved Hide resolved

internal/cmd/asyncapi/command_export.go Show resolved Hide resolved

Parth Agrawal (pagrawal10) added 2 commits October 3, 2022 10:25

removed lint errors

62a7e00

updated go mod files to remove lint errors

a0025b7

Parth Agrawal (pagrawal10) requested a review from Brian Strauch (brianstrauch) October 3, 2022 07:40

handling GenericOpenApiError

371df10

Brian Strauch (brianstrauch) approved these changes Oct 4, 2022

View reviewed changes

Calling /asyncapi endpoint to note metrics

e98a66d

Parth Agrawal (pagrawal10) requested a review from Brian Strauch (brianstrauch) November 2, 2022 12:54

Merge branch 'main' into AsyncAPI

2072245

Brian Strauch (brianstrauch) suggested changes Nov 2, 2022

View reviewed changes

internal/cmd/asyncapi/account_details.go Outdated Show resolved Hide resolved

internal/cmd/asyncapi/account_details.go Outdated Show resolved Hide resolved

resolving lint errors

a97dacb

Parth Agrawal (pagrawal10) requested a review from Brian Strauch (brianstrauch) November 3, 2022 09:48

Added AsyncAPI Metric to SDK

7a8b11f

Brian Strauch (brianstrauch) reviewed Nov 15, 2022

View reviewed changes

internal/cmd/asyncapi/account_details.go Outdated Show resolved Hide resolved

internal/cmd/asyncapi/account_details.go Outdated Show resolved Hide resolved

improving error message

97ed611

Parth Agrawal (pagrawal10) requested a review from Brian Strauch (brianstrauch) November 16, 2022 02:31

Brian Strauch (brianstrauch) approved these changes Nov 16, 2022

View reviewed changes

Parth Agrawal (pagrawal10) merged commit f795aec into main Nov 17, 2022

Parth Agrawal (pagrawal10) deleted the AsyncAPI branch November 17, 2022 11:12

Parth Agrawal (pagrawal10) restored the AsyncAPI branch November 18, 2022 05:35

Parth Agrawal (pagrawal10) deleted the AsyncAPI branch November 18, 2022 06:01

Conversation

Parth Agrawal (pagrawal10) commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

What

References

Test & Review

Uh oh!

Brian Strauch (brianstrauch) commented Jun 7, 2022

Uh oh!

Parth Agrawal (pagrawal10) commented Jun 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Brian Strauch (brianstrauch) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Parth Agrawal (pagrawal10) commented May 25, 2022 •

edited

Loading