Remove release target of renaming archives checksums file#1334
Merged
Conversation
Brian Strauch (brianstrauch)
approved these changes
Jun 24, 2022
Brian Strauch (brianstrauch)
left a comment
Brian Strauch (brianstrauch)
left a comment
There was a problem hiding this comment.
Nice! 💯 We should fix the naming in the next major release. It's confusing how archives and binaries don't use the same format. 😕
Contributor
Author
Yes. We might work on the installer script. All releases we have now have this discrepancy. We would want installer to work on previous ones still. |
Anshul Goyal (Anshul-Goyal)
pushed a commit
that referenced
this pull request
Jul 12, 2022
* Update release.mk * Update release.mk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
We used to rename it from
2.x.xtov2.x.xas the auto upload of goreleaser doesn't include thev, and our install script requires thatv. The new gorelease block we have now has already renamed it when uploading checksums files (after cating checksums of linux build), and this block would overwrite that.Keeping this
patchblock in case we need anything in the future.Also upload the cated checksums to github to overwrite the previous one without linux checksum.
References
Test & Review