[CLI-1559, CLI-1849] Add TTL to KafkaClusterConfig struct#1336
Merged
Brian Strauch (brianstrauch) merged 1 commit intomainfrom Jun 30, 2022
Merged
[CLI-1559, CLI-1849] Add TTL to KafkaClusterConfig struct#1336Brian Strauch (brianstrauch) merged 1 commit intomainfrom
KafkaClusterConfig struct#1336Brian Strauch (brianstrauch) merged 1 commit intomainfrom
Conversation
Brian Strauch (brianstrauch)
changed the title
KafkaClusterConfig structKafkaClusterConfig struct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
In https://confluent.slack.com/archives/C03L12X8C8M, the customer's Kafka API endpoint was updated, but since the CLI config never refreshes it, the customer's client didn't receive the new endpoint. In this PR, we add a 1 week TTL so that API endpoints are refreshed every week, so they can be updated again in the future without needing the customer to delete their config file. This gives backend teams 1 week to support both endpoints as they are transitioned.
References
https://confluentinc.atlassian.net/browse/CLI-1849
Test & Review
Added unit tests for TTL update logic