Fix confluent local panic#1372
Merged
Brian Strauch (brianstrauch) merged 1 commit intomainfrom Jul 26, 2022
Merged
Conversation
David Hyde (DABH)
approved these changes
Jul 26, 2022
Contributor
David Hyde (DABH)
left a comment
David Hyde (DABH)
left a comment
There was a problem hiding this comment.
Thanks, beat me to it!! :)
Contributor
|
We still need to see if this is broken in all CP 7.2.0 downloads though 😬 |
Author
We'd only patch the CLI if there's a major security vulnerability, right? David Hyde (@DABH) |
Contributor
|
Brian Strauch (@brianstrauch) I think it's also acceptable to update the CLI version with a CP patch release if there is a major functionality problem like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Fix panic when "plugin.path" is not specified. This value is not required by connect so it can be safely ignored.
References
https://confluent.slack.com/archives/C9Y6NAM6X/p1658842480998709
Test & Review
Manually reproduced and verified that the panic is gone.