CIAM-2206: CLI List roles command should return Ksql and SR roles with Stage 3 flag#1378
Merged
Akshay Ben (aben) (dragonmushu) merged 10 commits intomainfrom Aug 4, 2022
Merged
Conversation
Brian Strauch (brianstrauch)
approved these changes
Jul 28, 2022
Contributor
|
Changes Look Good .. Can we please add Unit Test in https://github.com/confluentinc/cli/blob/main/test/iam_test.go |
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
Akshay Ben (aben) (dragonmushu)
force-pushed
the
aben/updateCLIForKsqlAndSRRoles
branch
from
a466378 to
aa50087
Compare
Brian Strauch (brianstrauch)
approved these changes
Aug 4, 2022
| dataplaneRoles, _, _ := c.MDSv2Client.RBACRoleDefinitionsApi.Roles(c.createContext(), opts) | ||
| roles := append(publicRoles, dataplaneRoles...) | ||
| // add ksql and datagovernance roles | ||
| if os.Getenv("XX_DATAPLANE_3_ENABLE") != "" { |
There was a problem hiding this comment.
FYI, we have a feature flag framework that you can use in the future, it would give you some more flexibility over these features.
tadsul
reviewed
Aug 4, 2022
tadsul
reviewed
Aug 4, 2022
tadsul
approved these changes
Aug 4, 2022
Contributor
tadsul
left a comment
tadsul
left a comment
There was a problem hiding this comment.
LGTM -> merge after fixing the comments
Akshay Ben (aben) (dragonmushu)
deleted the
aben/updateCLIForKsqlAndSRRoles
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Allow sr and ksql roles to be listed with stage 3 flag present.