[DGS-4331] make sr cluster upgrade consistent#1383
Merged
Anshul Goyal (Anshul-Goyal) merged 3 commits intomainfrom Aug 5, 2022
Merged
[DGS-4331] make sr cluster upgrade consistent#1383Anshul Goyal (Anshul-Goyal) merged 3 commits intomainfrom
Anshul Goyal (Anshul-Goyal) merged 3 commits intomainfrom
Conversation
Anshul Goyal (Anshul-Goyal)
requested a review
from Dragos Misca (dragosvictor)
Dragos Misca (dragosvictor)
approved these changes
Aug 1, 2022
| SRInvalidPackageType = `"%s" is an invalid package type` | ||
| SRInvalidPackageSuggestions = "Allowed values for `--package` flag are: %s." | ||
| SRInvalidPackageUpgrade = `Schema Registry already uses "%s" package` | ||
| SRInvalidPackageUpgrade = "Environment \"%s\" is already using the Stream Governance \"%s\" package.\n" |
There was a problem hiding this comment.
Suggested change
| SRInvalidPackageUpgrade = "Environment \"%s\" is already using the Stream Governance \"%s\" package.\n" | |
| SRInvalidPackageUpgrade = "Environment \"%s\" is already using Stream Governance package \"%s\".\n" |
Contributor
Author
There was a problem hiding this comment.
In the UI, we're using the following messages -
Enable your Stream Governance essentials package or Upgrade to Stream Governance advanced package
So, I guess Environment "env-12345" is already using the Stream Governance "essentials" package. might be more consistent than Environment "env-12345' is already using Stream Governance package "essentials"
wdyt?
There was a problem hiding this comment.
I just suggested this since this is the wording we use for all of our other resources. Examples:
Deleted kSQL cluster "lksqlc-12345".
Error: failed to delete API key "123456789"
I'm not too picky though and I could see this going either way. Up to you and your team!
Anshul Goyal (Anshul-Goyal)
requested a review
from Brian Strauch (brianstrauch)
Brian Strauch (brianstrauch)
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Updating error message for schema-registry cluster upgrade consistent with the success message.
References
https://confluentinc.atlassian.net/browse/DGS-4331
Test & Review
Tested locally against stag.