[DGS-4369] Updating sr cluster delete confirmation message#1384
Merged
Anshul Goyal (Anshul-Goyal) merged 9 commits intomainfrom Aug 7, 2022
Merged
[DGS-4369] Updating sr cluster delete confirmation message#1384Anshul Goyal (Anshul-Goyal) merged 9 commits intomainfrom
Anshul Goyal (Anshul-Goyal) merged 9 commits intomainfrom
Conversation
Brian Strauch (brianstrauch)
left a comment
Brian Strauch (brianstrauch)
left a comment
There was a problem hiding this comment.
Thanks for updating the wording here 😅
Anshul Goyal (Anshul-Goyal)
requested a review
from Brian Strauch (brianstrauch)
Anshul Goyal (Anshul-Goyal)
changed the title
Brian Strauch (brianstrauch)
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Deleting the cluster is a destructive and irreversible operation, so :
Updating the confirmation message to explicitly call out the permanent nature of the operation.
(This change is also consistent with the UI)
References
https://confluentinc.atlassian.net/browse/DGS-4369
Test & Review
Tested against devel locally.